[p4] submit numbered changelist in command line client

[Jeff Grills]

P4 submit doesn't know about your trigger that checks the length
requirement.  When you submit the default changelist, perforce knows the
comment has to be the default because you can't put a comment on the default
changelist.  If you make a new numbered changelist, you have to fulfill that
requirement to have a real comment at that time, so submitting a numbered
changelist doesn't have to display the dialog to get you to enter a
changelist, and it doesn't.  You're exactly right in that you can use "p4
change" to edit that changelist before submitting.  It's a bit inconsistent
that the guis do pop up the dialog to edit even for numbered changelists.  I
don't know what else to say about that - we could ask perforce to be
consistent across all clients for that.

The "p4 revert" command run by p4win is probably due to an option that lets
you automatically deselect unchanged files before submitting.  It's simply
asking perforce which files would revert so that it can omit them from the
submission.  I suspect you have that option enabled - I see no reason for
perforce to execute it if it was disabled.

j

-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Greg Pan
Sent: Thursday, August 10, 2006 1:13 PM
To: perforce-user at perforce.com
Subject: [p4] submit numbered changelist in command line client


I have implemented a trigger (python script) which validates whether the
descriptions user enters meet the length requirement. It will fail if the
length is not met. The only *issue* happens in p4 command line client. The
fail scheme works fine - Perforce warns you that "Submit validation failed
-- fix problems then use 'p4 submit -c xxxx'.". What I expected was, upon
seeing that, I could do 'p4 submit -c xxxx', which would bring up the submit
form where I could edit my description to meet the requirement. But the
re-submit would actually fail right away again without giving me the chance
to edit the description. What I need to do is to execute 'p4 change xxxx',
which bring up the submit form with the editable description field.

 

My question is that why 'p4 submit -c xxxx' of command line client does not
give me the submit form? In p4win or p4v, the failed and numbered changelist
can be easily re-submit, as it does open up the submit form for you. So the
same attempt differs in different clients - at least to me.

 

By the way, when I try to submit a numbered changelist on p4win, I see 2
commands being executed, "p4 revert -an -c xxxx" followed by "p4 submit -o
xxxx". So probably the combination of the 2 differs from simply "p4 submit
-c xxxx"?

 

Thanks in advance.

 

Greg

 

 

_______________________________________________
perforce-user mailing list  -  perforce-user at perforce.com
http://maillist.perforce.com/mailman/listinfo/perforce-user