[p4] Code reviews

[Chuck Karish]

On 12/21/06, martin sweitzer <msewlists at gmail.com> wrote:
> On 12/3/06, Chuck Karish <chuck.karish at gmail.com> wrote:
> > For me, Mondrian's killer feature is that it saves multiple snapshots
> > of files during a review cycle.  The reviewer can choose to do a dif
> > that shows only the changes that were made in response to
> > review comments.
>
> It seems they could have used P4 in a separate branch for the code
> review process.  And once the review is done use the #head of the
> review branch to check into p4.

MUCH more expensive and at least as complicated as what Guido did.
And slower.   Easier to do on Subversion than on Perforce.

> So instead of creating all the infrastructure and writing their own
> diff tools ( SideNote:  why on earth are they not using Araxis Merge)

Windows only.

Mondrian diffs are done on the (web) server side.  Everything it does
works the same way on all client platforms.

> and basically own revision DB, they could have just automated creating
> new branches

The server is already dying under the weight of the necessary branches.

-- 
Chuck Karish   karish at well.com   (415) 317-0182