[p4] Submit triggers: how long is too long?
Todd Short (tshort)
tshort at cisco.com
Thu Jun 8 14:51:15 PDT 2006
We can't use Jobs for numerous reasons (i.e. our bug database uses
letters and numbers in the identifiers, the bug database is shared
across ALL products). This isn't about the bug database itself, but
something that references bugs.
i.e.
I have a bug identifier, and I want to look in database X (which is not
the bug database) for references to that bug identifier.
--
-Todd Short
// tshort at cisco.com
// "One if by land, two if by sea, three if by the Internet."
> -----Original Message-----
> From: Matthew Janulewicz [mailto:MJanulewicz at greendotcorp.com]
> Sent: Thursday, June 08, 2006 5:35 PM
> To: Todd Short (tshort); perforce-user at perforce.com
> Subject: RE: [p4] Submit triggers: how long is too long?
>
> I think the question is more for your users. The submits will take
> however long the script takes to run. And if the script
> silently fails,
> well, it could take in infinite amount of time :).
>
> A better tact might be to look into P4DTI and sync your bug database
> with Jobs. It's a lot easier for a script to query on the
> jobs that are
> built into Perforce and accept/reject them based on their status. Just
> make code review part of your bug workflow and check for that.
>
> I don't believe Perforce prevents anyone from doing anything on a file
> while it's being submitted, unless it is locked specifically upon
> checkout. Same rules apply to files that need to be resolved, etc.
> regardless of whether or not a submit trigger is being run.
>
>
> -Matt
>
>
> -----Original Message-----
> From: perforce-user-bounces at perforce.com
> [mailto:perforce-user-bounces at perforce.com] On Behalf Of Todd Short
> (tshort)
> Sent: Thursday, June 08, 2006 10:34 AM
> To: perforce-user at perforce.com
> Subject: [p4] Submit triggers: how long is too long?
>
> We are adding some additional process to our submission tasks.
> What we want to do is use a "submit" trigger to search a database for
> the bug ID to see if a code review has taken place.
>
> At this point, I'm not sure how long this script will take, so my
> question is "How long is too long?"
>
> Does anyone know what kind of locking occurs when a submit trigger is
> running? Are other people prevented from submitting? Or just the files
> to be submitted? Syncing?
>
> --
> -Todd Short
> // tshort at cisco.com
> // "One if by land, two if by sea, three if by the Internet."
>
> _______________________________________________
> perforce-user mailing list - perforce-user at perforce.com
> http://maillist.perforce.com/mailman/listinfo/perforce-user
>
More information about the perforce-user
mailing list