[p4] A tale of the review deamon and P4AUTH

[Ivey, William]

A while back I was trying to get p4review.py to run on a remote server
which was authenticating from the main server via P4AUTH. It wasn't
working because p4 reviews returns nothing in that case.

Suddenly I had an idea so simple that it just had to be wrong. But it
wasn't.

Replacing this line in p4review.py:
	  return parse_p4_review(p4 + ' reviews -c ' + change,ignore_author)
with:
	  return parse_p4_review(p4 + ' -p mainserver:1666 reviews -c ' + change,ignore_author)
made it all better.

And they lived happily ever after...

A neater trick would be to use the value in $P4AUTH directly, if it exists, of course.

-Wm
 X26150 (512-340-6150)