[p4] A tale of the review deamon and P4AUTH

[Russell C. Jackson]

That will not work properly. The command is going to ask the main server 
which users are reviewing a changelist number that was taken from the 
remote server, and it isn't going to match since that isn't the same 
changelist number on the main server, and it doesn't refer to the same code.

Thanks,
Rusty

--------------------------------------------------
RCJackson Consulting
Perforce Consulting Partner and Certified Trainer
--------------------------------------------------
Russell C. Jackson
211 River Oaks Lane
Russellville, AR 72802
--------------------------------------------------
rusty at rcjacksonconsulting.com
http://www.rcjacksonconsulting.com
tel:      479-696-9710
fax:      479-967-0963
mobile:   479-747-3845
--------------------------------------------------




Ivey, William wrote:
> A while back I was trying to get p4review.py to run on a remote server
> which was authenticating from the main server via P4AUTH. It wasn't
> working because p4 reviews returns nothing in that case.
>
> Suddenly I had an idea so simple that it just had to be wrong. But it
> wasn't.
>
> Replacing this line in p4review.py:
> 	  return parse_p4_review(p4 + ' reviews -c ' + change,ignore_author)
> with:
> 	  return parse_p4_review(p4 + ' -p mainserver:1666 reviews -c ' + change,ignore_author)
> made it all better.
>
> And they lived happily ever after...
>
> A neater trick would be to use the value in $P4AUTH directly, if it exists, of course.
>
> -Wm
>  X26150 (512-340-6150)
>
>
> _______________________________________________
> perforce-user mailing list  -  perforce-user at perforce.com
> http://maillist.perforce.com/mailman/listinfo/perforce-user
>
>
>
>