[p4] A tale of the review deamon and P4AUTH

[Ivey, William]

Part of our issue was that 2005.2 wasn't avialable for our
server machine. However, we were finally able to upgrade its
OS to one Perforce supports as of yesterday so moving up is
a possibility now.

Otherwise, for now, I think the quickest way to a solution is
to bypass p4 reviews. I have a script that does just that for
daily reviews, unfortunately, it's written in Bourne shell
and the remote server is Windows. Rather than try to get it
working with cygwin, I think I'll just rewrite it in perl
or python.

-Wm


> -----Original Message-----
> From: Russell C. Jackson [mailto:rusty at rcjacksonconsulting.com]
> Sent: Wednesday, June 28, 2006 1:57 PM
> To: Ivey, William
> Cc: Perforce userlist (E-mail)
> Subject: Re: [p4] A tale of the review deamon and P4AUTH
> 
> 
> You may want to consider using the new authentication 
> triggers in 2005.2 
> instead of P4AUTH. You can use the trigger to authenticate 
> against your 
> main Perforce server, then you can create a couple of form-in 
> triggers 
> on the main server to replicate user and group changes on the main 
> server out to the remote servers to accomplish the same thing that 
> P4AUTH does without the limitations of P4AUTH.
> 
> The other triggers you would need would be a couple of triggers to to 
> block users from running p4 user and p4 group on the remote 
> server, and 
> tell them to make their changes on the main server instead, 
> or possibly, 
> you may want to try to pass the info. through from the main 
> server via 
> the trigger, but it probably easier to just tell them to use the main 
> server instead.
> 
> I personally would just ignore the user and group portion of this and 
> allow each server to have its own users and groups since the code on 
> each server is different, and it makes more sense for me to 
> maintain the 
> users and groups on the same server. The authentication 
> trigger wouuld 
> solve the problem of the users having multiple passwords, and 
> the admin 
> having to worry about keeping them all in sync. That is the 
> main problem 
> I want solved, and the authentication trigger takes care of 
> that without 
> having to deal with the limitations of P4AUTH.
> 
> Thanks,
> Rusty
> 
> --------------------------------------------------
> RCJackson Consulting
> Perforce Consulting Partner and Certified Trainer
> --------------------------------------------------
> Russell C. Jackson
> 211 River Oaks Lane
> Russellville, AR 72802
> --------------------------------------------------
> rusty at rcjacksonconsulting.com
> http://www.rcjacksonconsulting.com
> tel:      479-696-9710
> fax:      479-967-0963
> mobile:   479-747-3845
> --------------------------------------------------
> 
> 
> 
> 
> Ivey, William wrote:
> > You're right. Oddly enough, it works for me, but not other
> > users. In fact, I get emails whether I want them or not (it's
> > ignoring my Reviews entry and sending me emails for every new
> > change on the remote server).
> >
> > That mislead me into thinking it was working.
> >
> > Looks like I'll have to write my own that doesn't depend on the
> > reviews command after all. -Wm
> >
> >
> >   
> >> -----Original Message-----
> >> From: Russell C. Jackson [mailto:rusty at rcjacksonconsulting.com]
> >> Sent: Wednesday, June 28, 2006 12:59 PM
> >> To: Ivey, William
> >> Cc: Perforce userlist (E-mail)
> >> Subject: Re: [p4] A tale of the review deamon and P4AUTH
> >>
> >>
> >> That will not work properly. The command is going to ask the 
> >> main server 
> >> which users are reviewing a changelist number that was 
> taken from the 
> >> remote server, and it isn't going to match since that 
> isn't the same 
> >> changelist number on the main server, and it doesn't refer to 
> >> the same code.
> >>
> >> Thanks,
> >> Rusty
> >>
> >> --------------------------------------------------
> >> RCJackson Consulting
> >> Perforce Consulting Partner and Certified Trainer
> >> --------------------------------------------------
> >> Russell C. Jackson
> >> 211 River Oaks Lane
> >> Russellville, AR 72802
> >> --------------------------------------------------
> >> rusty at rcjacksonconsulting.com
> >> http://www.rcjacksonconsulting.com
> >> tel:      479-696-9710
> >> fax:      479-967-0963
> >> mobile:   479-747-3845
> >> --------------------------------------------------
> >>
> >>
> >>
> >>
> >> Ivey, William wrote:
> >>     
> >>> A while back I was trying to get p4review.py to run on a 
> >>>       
> >> remote server
> >>     
> >>> which was authenticating from the main server via P4AUTH. 
> It wasn't
> >>> working because p4 reviews returns nothing in that case.
> >>>
> >>> Suddenly I had an idea so simple that it just had to be 
> >>>       
> >> wrong. But it
> >>     
> >>> wasn't.
> >>>
> >>> Replacing this line in p4review.py:
> >>> 	  return parse_p4_review(p4 + ' reviews -c ' + 
> >>>       
> >> change,ignore_author)
> >>     
> >>> with:
> >>> 	  return parse_p4_review(p4 + ' -p mainserver:1666 
> >>>       
> >> reviews -c ' + change,ignore_author)
> >>     
> >>> made it all better.
> >>>
> >>> And they lived happily ever after...
> >>>
> >>> A neater trick would be to use the value in $P4AUTH 
> >>>       
> >> directly, if it exists, of course.
> >>     
> >>> -Wm
> >>>  X26150 (512-340-6150)
> >>>
> >>>
> >>> _______________________________________________
> >>> perforce-user mailing list  -  perforce-user at perforce.com
> >>> http://maillist.perforce.com/mailman/listinfo/perforce-user
> >>>
> >>>
> >>>
> >>>   
> >>>       
> >>     
> >
> >
> >
> >
> >   
> 
>