[p4] Code reviews

[Ivey, William]

> -----Original Message-----
> From: perforce-user-bounces at perforce.com
> [mailto:perforce-user-bounces at perforce.com]On Behalf Of 
> martin sweitzer
> 
> It seems they could have used P4 in a separate branch for the code
> review process.  And once the review is done use the #head of the
> review branch to check into p4.
> 
> So instead of creating all the infrastructure and writing their own
> diff tools ( SideNote:  why on earth are they not using Araxis Merge)
> and basically own revision DB, they could have just automated creating
> new branches

I think the key (and benefit) is that this system keeps the file in a
working development environment where any changes made during review
can immediately be built and tested. If it was checked into a review
branch, someone, somewhere, would have to create a build environment
and sync the file(s) from the review branch into it.

In many cases, being able to compile and test as you review will be
superior to simply looking over the code, or the hassle of creating
a duplicate build environment. (Although, if the latter were
automated enough - and resources were available - it would do the
job too.)

-Wm