[p4] Simple Code Review Tool

[Jeff Grills]

I have a tool in my perforce public directory called p4tar.pl which will
archive up a changelist into a single file that can be extracted on a
different client.  I've used this tool for reviews.  It's handy in that you
get the changelist on your machine and you can use whatever diff tools you
like with perforce, and you could even build and test the changes if you'd
like.  One down side is that if you use your normal client for reviewing,
you need to make sure that you don't already have those files open or you
could blow away your changes.  The tool doesn't handle integrations as well
as it could, but it can convert them into edits/adds/deletes (a feature
added in part to enable reviewing of integrated changelists).

I also use this tool to move work from one machine to another (for example,
the office to home and back again), as well as to test out changes on other
platforms before submitting.

The tool is a bit picky about its environment - it likes unix, but works
well under Windows with ActiveState perl and cygwin.  I hope to fix that one
day.

j

-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Scott Marshall
Sent: Friday, July 27, 2007 7:56 PM
To: perforce-user at perforce.com
Subject: [p4] Simple Code Review Tool


Hi there,

Has anyone created a simple code review tool for Perforce
that allows developers to review code changes before they
are submitted to the depot? One of my developers is
working on a simple email that would be sent to a
reviewer containing the output of the p4diff command.
However he is running into a problem figuring out how to
handle new files that are being added as part of the
pending changelist. Any insights would be helpful?

Thanks,

-Scott

Scott Marshall | Build Engineer

Citrix Online Division 		Phone: 805.690.5832
Citrix Systems, Inc.		Fax: 805. 690.6471 
5385 Hollister Avenue		Email:
scott.marshall at citrix.com 	
Santa Barbara, CA 93111 USA	Web: www.citrix.com