[p4] Simple Code Review Tool

[Bennett, Patrick]

I completely disagree.  To say that using a code review tool will cause
people to stop using SCM is rubbush.
You want to catch problems *before* they're submitted - particularly
fixes to existing code.
We don't require code reviews on tip code, but any 'hotfixes' to any
currently shipping code will require code review.
We're still evaluating Code Collaborator
(http://www.smartbearsoftware.com/codecollab.php) but so far, it seems
to be going very well.
It integrates very well with Perforce (including triggers) and it looks
like we'll probably buy it.

Patrick


-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Paul Goffin
Sent: Saturday, July 28, 2007 3:29 AM
To: 'Scott Marshall'; perforce-user at perforce.com
Subject: Re: [p4] Simple Code Review Tool

It's a Big Mistake to do this.

If you put barriers between your SCM system and your developers
they'll stop using it and it wont be long before you have code out
in the world that isn't in your system but is on a developers
workstation waiting to be checked in when he "gets round to it".

Let your developers submit code freely to a development branch
and then run your review tool before the branch is integrated into
the mainline.

Paul.




-----Original Message-----
Sent: 28 July 2007 01:56
To: perforce-user at perforce.com
Subject: [p4] Simple Code Review Tool


Hi there,

Has anyone created a simple code review tool for Perforce
that allows developers to review code changes before they
are submitted to the depot? One of my developers is
working on a simple email that would be sent to a
reviewer containing the output of the p4diff command.
However he is running into a problem figuring out how to
handle new files that are being added as part of the
pending changelist. Any insights would be helpful?

Thanks,

-Scott

Scott Marshall | Build Engineer


No virus found in this outgoing message.
Checked by AVG Free Edition. 
Version: 7.5.476 / Virus Database: 269.10.22/923 - Release Date:
27/07/2007
18:01
 
_______________________________________________
perforce-user mailing list  -  perforce-user at perforce.com
http://maillist.perforce.com/mailman/listinfo/perforce-user