[p4] Simple Code Review Tool

[Jeff A. Bowles]

The issue, for me, is when the review is mandatory
and applies to every checkin (including tools, sandboxes,
and production development and release lines).

(Don't laugh.  This environment exists. The
"unintended consequences" are pretty ugly.)

A few thoughts - it's important to have these discussions
instead of decreeing that something is "bad" or "evil",
since you know your developers will need more than a decree.

The key thing is, a "process" should not enjoin someone from doing
simple things easily.

What is the real engineering goal, to avoid putting bad things into
a program or to avoid giving bad things to a customer? (This is not
a false choice; the question of when to do a review hinges on it.)

If the trade-off is development time lost (due to waiting for
reviews) versus development time lost (due to idiot code breaking
things), shouldn't that be part of the discussion?

----

The  information about "Code Collaborator" is very helpful,
by the way. (Wish their tools were on Linux and Mac OS X.)

   -Jeff Bowles