[p4] Simple Code Review Tool

[Rene Medellin]

Cenqua's Crucible works a treat.

http://www.cenqua.com/crucible/


--- paul goffin <paul.goffin at dsl.pipex.com> wrote:

> Quoting "Bennett, Patrick"
> <Patrick.Bennett at inin.com>:
> 
> > I completely disagree.
> 
> Perhaps I haven't expressed my point very well.
> 
> > To say that using a code review tool will cause
> > people to stop using SCM is rubbush.
> 
> Developers are bright, busy people.  The more
> barriers you put
> in front of them doing what they see as 'their job'
> the bigger
> the incentive you give them to look for ways round
> those barriers.
> 
> > You want to catch problems *before* they're
> submitted - particularly
> > fixes to existing code.
> 
> Ideally you do, yes.  But regardless of that, what
> you 100% _need_
> is that you can find the source code of your
> product.
> 
> Developers can be very good at working their way
> round rigid QA
> systems that, as they see it, "get in the way". 
> Stop them
> submitting because of non compliance with a QA stage
> and you'll
> soon find your SCM system slipping into disuse.
> 
> > We don't require code reviews on tip code, but any
> 'hotfixes' to any
> > currently shipping code will require code review.
> 
> I'm not saying "don't review".  I'm saying "don't
> prevent
> developers submitting code".
> 
> (After all that was one of the founding notions of
> Perforce in the
> first place.)
> 
> Let developers submit.  _Then_ do the review.
> 
> (If you do use a trigger, use the trigger to produce
> a report,
> not prevent submission.
> 
> Or use a demon.)
> 
> Paul.
> 
> -- 
> _______________________________________________
> perforce-user mailing list  - 
> perforce-user at perforce.com
>
http://maillist.perforce.com/mailman/listinfo/perforce-user
> 



       
____________________________________________________________________________________
Looking for a deal? Find great prices on flights and hotels with Yahoo! FareChase.
http://farechase.yahoo.com/