[p4] Simple Code Review Tool

[Ivey, William]

> To say that using a code review tool will cause people to
> stop using SCM is rubbush.

Never underestimate the power of developers to avoid something
they consider a speedbump. After we introduced Perforce, one
developer submitted changes with "." as the complete text of
the comment. Why? Because Peforce, at the time, would not
accept the comment on the command line and he couldn't be
bothered to edit the form. It was a couple of weeks and a
couple of discussions with his manager before that changed.
(And, no, firing this developer was never an option.)

> We don't require code reviews on tip code, but any
> 'hotfixes' to any currently shipping code will require
> code review.

That's a reasonable compromise. I'd still be cautious if the
review process is so sluggish that code ends up sitting only
on a developer's machine for extended periods.

-Wm

-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Bennett,
Patrick

I completely disagree.  To say that using a code review tool will cause
people to stop using SCM is rubbush.
You want to catch problems *before* they're submitted - particularly
fixes to existing code.
We don't require code reviews on tip code, but any 'hotfixes' to any
currently shipping code will require code review.
We're still evaluating Code Collaborator
(http://www.smartbearsoftware.com/codecollab.php) but so far, it seems
to be going very well.
It integrates very well with Perforce (including triggers) and it looks
like we'll probably buy it.

Patrick