[p4] Simple Code Review Tool

[Heck, Joe]

You might also check out ReviewBoard
http://code.google.com/p/reviewboard/  (developed and opened by some
folks at VMWare) I haven't used it - so no endorsement, but the VMWare
folks are a Perforce Shop.

-joe

-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Jay Glanville
Sent: Monday, July 30, 2007 9:32 AM
To: Scott Marshall; perforce-user at perforce.com
Subject: Re: [p4] Simple Code Review Tool

One open-source possibility is CodeStriker
(http://codestriker.sourceforge.net/).  It does integrate with P4, not
100%, but for the cost it does a pretty good job.

You start a topic and then upload a delta to it (I had to write a very
small bash script that would take the unified diff output of a pending
change list and reformat it for what CodeStriker needed).  You would
then invite people to your topic, and they would review it and comment
on it.  I believe that CS actually goes to P4 to get the head copy of a
file, so when it's showing a side-by-side diff, you're actually seeing
the live file with the person's changes.

If you're really ambitious, you could write a trigger that does not
allow a check in until the status of the CodeStriker topic is
"approved", or something similar...

JDG

---
Jay Dickon Glanville


> -----Original Message-----
> From: perforce-user-bounces at perforce.com 
> [mailto:perforce-user-bounces at perforce.com] On Behalf Of 
> Scott Marshall
> Sent: July 27, 2007 8:56 PM
> To: perforce-user at perforce.com
> Subject: [p4] Simple Code Review Tool
> 
> 
> Hi there,
> 
> Has anyone created a simple code review tool for Perforce
> that allows developers to review code changes before they
> are submitted to the depot? One of my developers is
> working on a simple email that would be sent to a
> reviewer containing the output of the p4diff command.
> However he is running into a problem figuring out how to
> handle new files that are being added as part of the
> pending changelist. Any insights would be helpful?
> 
> Thanks,
> 
> -Scott
> 
> Scott Marshall | Build Engineer
> 
> Citrix Online Division 		Phone: 805.690.5832
> Citrix Systems, Inc.		Fax: 805. 690.6471 
> 5385 Hollister Avenue		Email:
> scott.marshall at citrix.com 	
> Santa Barbara, CA 93111 USA	Web: www.citrix.com 
> 
> 
> _______________________________________________
> perforce-user mailing list  -  perforce-user at perforce.com
> http://maillist.perforce.com/mailman/listinfo/perforce-user
> 

_______________________________________________
perforce-user mailing list  -  perforce-user at perforce.com
http://maillist.perforce.com/mailman/listinfo/perforce-user