[p4] Simple Code Review Tool

[Ivey, William]

The question was never really whether or not to do code reviews,
the question was do you prevent checkins until the code is
reviewed, or do you allow checkins and then review the code
before promoting it to the build or production branch (or find
some other method that doesn't delay code capture from the
developer's workspaces).

My feeling is, judge the risk and try to minimize it. Blocking
checkins when people are developing code at high speed is risky.
Allowing unreviewed checkins in stable branches is also risky.
You don't have to apply the same policy everywhere.

As far as firing developers: When the developer in question is
the only authority on your core product, firing isn't usually
an option. (Threatening them with more, and boring, work usually
works better :-) 

-Wm


-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Slava Imeshev

> -----Original Message-----
> Never underestimate the power of developers to avoid 
> something they consider a speed bump. 

Putting aside the general discussion on the value of code reviews,
sometimes a code review is a requirement that is a part of the job
description (defense, aviation, space, healthcare, gambling etc). 

Among our customers a requirement not to go home until the build is
seen clean is not uncommon.

In such conditions an efficient tool is important, both to enable the
process and to encourage conformance among its users.

> It was a couple of 
> weeks and a couple of discussions with his manager before 
> that changed.
>
> (And, no, firing this developer was never an option.)

As the original poster mentioned, for them, the review could be a
matter of life or death. So the above may well be an option (if not
the only option).

Regards,

Slava Imeshev
vimeshev at viewtier.com
www.viewtier.com
_______________________________________________
perforce-user mailing list  -  perforce-user at perforce.com
http://maillist.perforce.com/mailman/listinfo/perforce-user