[p4] perforce-user Digest, Vol 34, Issue 5
chuck.karish at gmail.com
Tue Oct 9 09:16:20 PDT 2007
On 10/9/07, Toby Allen <tallen at qumas.com> wrote:
> If you are doing this kind of thing, it may be much better to set up a
> system of branches that can
> Be used to review code against rather than passing around numbers of
> non-submitted changelists. One of the
> Really big benefits of perforce is that is makes branching so easy that
> there is no reason not to submit
> Code even if you submit it only against your own personal branch.
> Take a look at settin up a system where your developers will submit
> against a dev branch, they then pass the submitted
> Changelist number for someone to review, if it passes it is integrated
> into the mainline. This does exactly what
> You want but in the way that Perforce intends.
Have you done this? It's easy to create a sparse private branch into
which a developer can submit a provisional change. It's not so easy
to make this change available to the reviewer so it can be examined
in the context of the shared code line. There are other gotchas to
consider, too. For example, what if a developer has two changes in
review that affect the same file?
Chuck Karish karish at well.com (415) 317-0182
More information about the perforce-user