[p4] Diff for specific changeset?

[Dave Lewis]

I have several thoughts...  The idea is code review, so I don't really
see sending diffs as a very nice way to do code reviews.  I am
surprised that nobody has mentioned p4tar as a means to package up the
changes to send to somebody for review.  There have been discussions
in the past about whole systems devoted to code review, I can't recall
their names offhand though.

dave


On 10/9/07, Sam Clegg <sam at ideaworks3d.com> wrote:
>
> On Mon, 2007-10-08 at 10:32 -0700, Michael Graff wrote:
> > If you don't mind a GUI solution, you can select subsets of files in
> > the Pending tab of P4V, then diff the selected files.
>
> This doesn't help for scenario where I want to send one of my pending
> changelists to a friend does it?
>
> Is there anyone on this list from perfroce who might like to add this
> feature?  Please :)
>
>
> >
> > On 10/8/07, Roy Smith <smith_roy at emc.com> wrote:
> > > Yes, but what I'm trying to figure out is how to make it suppress
> > > things that are not on the default changelist, so I can see exactly
> > > what's going to get submitted when I do "p4 submit".
> > >
> > > On Oct 8, 2007, at 9:56 AM, Stephen Vance wrote:
> > >
> > > > 'p4 diff' with no arguments shows you the diff of everything that
> > > > is open against the have version in the current or specified
> > > > workspace.
> > > >
> > > > Steve
> > > >
> > > > Roy Smith wrote:
> > > >> Is there anyway to restrict "p4 diff" to just show you the diffs
> > > >> for  a specific pending change set (or the default changeset)?  In
> > > >> other  words, I want to see the changes that will be submitted
> > > >> when I do "p4  submit".
> > > >>
> > > >> -------------------
> > > >> Roy Smith <smith_roy at emc.com>
> > > >> Software Guy, EMC Common Management Group
> > > >> 44 South Broadway, 7th floor
> > > >> White Plains, NY 10601
> > > >> (914) 580-3427
> > > >> AIM: roysmith649
> > > >>
> > > >> _______________________________________________
> > > >> perforce-user mailing list  -  perforce-user at perforce.com
> > > >> http://maillist.perforce.com/mailman/listinfo/perforce-user
> > > >>
> > > >>
> > > >
> > > > --
> > > > Stephen Vance
> > > > www.vance.com
> > > >
> > > >
> > >
> > > -------------------
> > > Roy Smith <smith_roy at emc.com>
> > > Software Guy, EMC Common Management Group
> > > 44 South Broadway, 7th floor
> > > White Plains, NY 10601
> > > (914) 580-3427
> > > AIM: roysmith649
> > > _______________________________________________
> > > perforce-user mailing list  -  perforce-user at perforce.com
> > > http://maillist.perforce.com/mailman/listinfo/perforce-user
> > >
> > _______________________________________________
> > perforce-user mailing list  -  perforce-user at perforce.com
> > http://maillist.perforce.com/mailman/listinfo/perforce-user
> --
> sam clegg
> sam at ideaworks3d.com
>
> _______________________________________________
> perforce-user mailing list  -  perforce-user at perforce.com
> http://maillist.perforce.com/mailman/listinfo/perforce-user
>
>
>