[p4] Diff for specific changeset?

[Sam Clegg]

On Tue, 2007-10-09 at 10:11 -0500, Dave Lewis wrote:
> I have several thoughts...  The idea is code review, so I don't really
> see sending diffs as a very nice way to do code reviews.  I am
> surprised that nobody has mentioned p4tar as a means to package up the
> changes to send to somebody for review.  There have been discussions
> in the past about whole systems devoted to code review, I can't recall
> their names offhand though.

Its not just for code review.  If I have 20 outstanding changelists and
I'm about to submit one of them the fist thing I'm going to want to do
is eyeball the combined diff of all the files in the changelist (the
evquiv for GUI users of selecting all the files in the changelist and
pressing ctrl-d).

Also, tools like p4tar and things the "shelve" changes would be far
simpler to write/read/develop if "p4 describe" was capable of showing
local diffs.


-- 
sam clegg
sam at ideaworks3d.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://maillist.perforce.com/pipermail/perforce-user/attachments/20071009/534693c9/attachment.bin