[p4] Diff for specific changeset?

[Chuck Karish]

On 10/10/07, Toby Allen <tallen at qumas.com> wrote:
> I dont understand however how  it can be difficult to get access
> to a change.  Every submitted changelist is available on the submitted
> tab to every other developer who has read access. By passing around
> a submitted changelist number you can allow people to view the
> submitted changelist, do a diff against previous revision to get changes
> (hence two changes to the same file can be seperate changelists).  Viewing
> it in context of the shared codeline I dont understand,

By this I meant having the modified files present as part of a full buildable
client.  It's a lot easier to do a good review when you can make sure the
files compile and can run static analysis tools on them.

> but if anything using
> non-submitted files makes this harder not easier.
>
> If you work with a system like this, a reviewer could then integrate the
> change they have reviewed into the main codeline.

The need to do this poses an extra barrier to doing a proper review.
I'd hope that a good review tool would make this part completely
transparent.

-- 
Chuck Karish   karish at well.com   (415) 317-0182