[p4] Diff for specific changeset?

[Ivey, William]

> By this I meant having the modified files present as part of a
> full buildable client.

Having them submitted to a review branch doesn't preclude that.
You can create the review client to give preference to any
files on the the review branch (making it effectively a sparse
branch) or give preference to the live code line but still
allow selected files from the branch to be synced.

What the client syncs depends on both the order of the lines
in the view and on which side of the view matches what was used
in the sync command. (That is, using local syntax I might get
files from the review branch, but using the depot path I could 
force it to use files from the live code line.)

-Wm


-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Chuck Karish

On 10/10/07, Toby Allen <tallen at qumas.com> wrote:
> I dont understand however how  it can be difficult to get access
> to a change.  Every submitted changelist is available on the submitted
> tab to every other developer who has read access. By passing around
> a submitted changelist number you can allow people to view the
> submitted changelist, do a diff against previous revision to get
changes
> (hence two changes to the same file can be seperate changelists).
Viewing
> it in context of the shared codeline I dont understand,

By this I meant having the modified files present as part of a full
buildable
client.  It's a lot easier to do a good review when you can make sure
the
files compile and can run static analysis tools on them.

> but if anything using
> non-submitted files makes this harder not easier.
>
> If you work with a system like this, a reviewer could then integrate
the
> change they have reviewed into the main codeline.

The need to do this poses an extra barrier to doing a proper review.
I'd hope that a good review tool would make this part completely
transparent.

-- 
Chuck Karish   karish at well.com   (415) 317-0182
_______________________________________________
perforce-user mailing list  -  perforce-user at perforce.com
http://maillist.perforce.com/mailman/listinfo/perforce-user