[p4] Diff for specific changeset?

[Ivey, William]

> Do you have a tool

No. Unfortunately. This isn't a method of review that any
teams here have expressed an interest in so there's been no
incentive to automate it. (Not every team is even doing
reviews, for that matter.)

There is one hack that cuts down on some of the effort.
You can "comment out" a view line by making the client
side something impossible to match. (OK, not really
impossible, but very unlikely.) That way you can leave
the lines in the client spec for reference and easy
activiation. Not at all perfect - the server side can
still be matched, for one thing - but I've used it when
dealing with multiple overlaid sparse branches for special
builds.

-Wm


-----Original Message-----
From: Chuck Karish [mailto:chuck.karish at gmail.com] 
Sent: Saturday, October 13, 2007 10:11 PM

On 10/13/07, Ivey, William <william_ivey at bmc.com> wrote:
> > By this I meant having the modified files present as part of a
> > full buildable client.
>
> Having them submitted to a review branch doesn't preclude that.
> You can create the review client to give preference to any
> files on the the review branch (making it effectively a sparse
> branch) or give preference to the live code line but still
> allow selected files from the branch to be synced.
>
> What the client syncs depends on both the order of the lines
> in the view and on which side of the view matches what was used
> in the sync command. (That is, using local syntax I might get
> files from the review branch, but using the depot path I could
> force it to use files from the live code line.)
>
> -Wm

Of course this can be done.  What I said was that it's complicated.

Do you have a tool that branches a changelist to a private branch
and maintains the reviewer's client spec so that changelist can
be seen as if it were part of the main code line, cleaning up the
client when the review is done?  I'd like to try it out.

-- 
Chuck Karish   karish at well.com   (415) 317-0182