[p4] A trigger change-submit deadlock

Rex Tener rex_tener at yahoo.com
Fri Sep 7 10:53:24 PDT 2007


I am trying to write a trigger that validates that a "reviewed by 
xxxx" string is contained in a submit description.  I have it trigger 
on a change-submit.  It works fine with p4v.  However, with the p4 
command line this creates a deadlock if the string is not 
present.  The steps are:

     1.  Submit without the required string
     2.  The submit errors correctly
     3.  The perforce server moves the default changelist to a 
numbered changelist
     4.  It displays "Use 'p4 submit -c XXXXXX' to submit file(s) in 
pending change XXXXXX"

However, now I am in a deadlock when trying to resubmit using "p4 
submit -c XXXXX" as the comment does not contain the string and it 
goes through the above four steps again.  How do I get it to show the 
submit form to the user?

     A.  Do I have to delete their comment?  (that is going to fly 
like a lead balloon)
     B.  Move their files back to the default changelist?
     C.  I missing something that is trivial because everyone 
validates changelist description
         and file contents and it can't be this hard.  :-)

Even looking at the Perforce job number validation example on page 
102 in the 2007.2 systems administrator's guide looks like it would deadlock.

Thanks,

Rex Tener
rex_tener at yahoo.com


More information about the perforce-user mailing list