[p4] Submit-change file locking issue

[Jamison, Shawn]

I realized that having the trigger fail and leave the files locked may
not be a bad thing.  
When the authorized to submit person go to edit a file to fix a
stability issue for example and finds the file he wants to edit locked
by someone else.  
He will have to 
*	Go and discuss with that user what changes are in that file.  
*	He may find that the fix he needs already exists and is just
waiting to be checked in. 

I like the open permission idea and it doesn't lock the files.  
I just don't' like having to tinker with the protect table. 


-Shawn Jamison>
Ciena Corp.
Perforce Admin

-----Original Message-----
From: perforce-user-bounces at perforce.com
[mailto:perforce-user-bounces at perforce.com] On Behalf Of Jeff A. Bowles
Sent: Friday, April 18, 2008 7:14 PM
To: Evgeny
Cc: perforce-user at perforce.com
Subject: Re: [p4] Submit-change file locking issue

I think that I would ask Tech Support before using this strategy; the
behavior of the submit-process (the 'pipeline' of what it is doing)
might make assumptions that the file remains locked and that no one
touches it during-the-submit except the submit-code.
Separately, I sent a different suggestion to Shawn: if you're trying to
stop check-ins for a while on a particular codeline, read up on the
"open"
permission....

What I wrote:

I would read up on "open" permission, which is half-way between "read"
and "write".

It is "permission to checkout/add/delete but not to 'submit' the
operation.
You can 'diff', see the files on your pending changelists, and 'revert',
but not 'submit'." (Someone has to give you temporary 'write' permission
to do that 'submit'.)

For a released codeline or a problematic development line, it's a very
good first-line technique to reach for. Fast, easy, reliable, and
easy-to-explain.

Give people "open" permission on that codeline, but reserve "write"
permission for the people working on specific stabilization of the code
"right now."


   -Jeff


On Fri, Apr 18, 2008 at 2:39 PM, Evgeny <evgeny.zislis at gmail.com> wrote:

> Just add an unlock inside the trigger.
> The files are locked before the trigger is fired, so unlocking them 
> inside the trigger will effectively disable the locking.
>
> On Fri, Apr 18, 2008 at 6:38 PM, Jamison, Shawn <sjamison at ciena.com>
> wrote:
> > Is there a way to prevent a submit-change trigger that fails from  
> > locking all the files in the change list?
> >
> >  I have a situation where this would be useful.
> >
> >  Thanks
> >  -Shawn Jamison>
> >  Ciena Corp.
> >  Perforce Admin
> >
> >  _______________________________________________
> >  perforce-user mailing list  -  perforce-user at perforce.com  
> > http://maillist.perforce.com/mailman/listinfo/perforce-user
> >
> _______________________________________________
> perforce-user mailing list  -  perforce-user at perforce.com 
> http://maillist.perforce.com/mailman/listinfo/perforce-user
>



--
---
Jeff Bowles - jeff.a.bowles at gmail.com
_______________________________________________
perforce-user mailing list  -  perforce-user at perforce.com
http://maillist.perforce.com/mailman/listinfo/perforce-user