[revml] [PATCH] VCP::Logger and STDOUT.

Barrie Slaymaker barries@slaysys.com
Wed, 8 Sep 2004 05:59:56 -0400


Applied, thanks.

On Tue, Sep 07, 2004 at 07:04:43PM +0100, Chia-liang Kao wrote:
> This breaks svk tests when delay loading VCP, as the the default
> output is selected to a scalar.
> 
> ----------------------------------------------------------------------
> r1050:  clkao | 2004-09-07T18:01:46.084672Z
> 
> Don't assume STDOUT was the old FH.
> ----------------------------------------------------------------------
> --- local/lib/VCP/Logger.pm  (revision 1049)
> +++ local/lib/VCP/Logger.pm  (revision 1050)
> @@ -344,9 +344,9 @@ BEGIN {
>     ## Flush the LOG every print() so that we never miss data and
>     ## so that we can pass the log to child processes to emit STDOUT
>     ## and STDERR to.
> -   select LOG;
> +   *OLDFH = select LOG;
>     $| = 1;
> -   select STDOUT;
> +   select OLDFH;
>  
>     ## Print a header line guaranteed to start at the beginning of a
>     ## line.
> 
> Cheers,
> CLK