[revml] [PATCH] VCP::Logger and STDOUT.

Chia-liang Kao clkao@clkao.org
Wed, 8 Sep 2004 16:14:14 +0100


--45Z9DzgjV8m4Oswq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 08, 2004 at 10:38:43AM -0400, Barrie Slaymaker wrote:
> I'm hesitant to require only the very latest Perl, so I'm not sure what
> to do.  Ideas?

This turns out to be wrong.  However just using a ref instead of raw
glob to hold the handle makes pperl happy

--- lib/VCP/Logger.pm  (revision 1069)
+++ lib/VCP/Logger.pm  (local)
@@ -344,9 +344,9 @@ BEGIN {
    ## Flush the LOG every print() so that we never miss data and
    ## so that we can pass the log to child processes to emit STDOUT
    ## and STDERR to.
-   *OLDFH =3D select LOG;
+   my $old =3D select LOG;
    $| =3D 1;
-   select OLDFH;
+   select $old;
=20
    ## Print a header line guaranteed to start at the beginning of a
    ## line.


Cheers,
CLK

--45Z9DzgjV8m4Oswq
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFBPyHGk1XldlEkA5YRApbOAKCCkeDmplLbwF1u6+n0Qb9F+uIeTwCeKJxf
O47lmpgh6SuFhxxoOQVvOGM=
=kEbm
-----END PGP SIGNATURE-----

--45Z9DzgjV8m4Oswq--